Closed pulkitsinghal closed 9 years ago
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."
@slnode ok to test
@pulkitsinghal thank you for the pull request.
I still don't like the idea of adding Makefile, it is a Unix-centric approach that AFAIK does not work on Windows, definitely not out of the box.
Even when you don't have mocha installed, you can still configure npm test
to use the one installed in loopback-testing, just replace mocha
with the full path:
"test": "./node_modules/loopback-testing/node_modules/.bin/mocha"
Could you please update your PR? (git commit --amend && git push -f
would work best)
@bajtos - I squashed everything into one commit and made the suggested edits too.
One last thing - please reword the commit to describe the change you made, instead of pointing to an external record. Also use present tense and make sure the first line is max 50 chars (see 50/72 rule).
Example:
README: add basic mocha setup instructions
Or perhaps
README: add basic mocha setup instructions
Update README with instructions on how to configure `npm test`
to run unit tests using mocha.
Done.
Landed, thank you!
Close #34