Assertion shouldBeAllowed is confusing

strongloop-archive / loopback-testing

DEPRECATED Utilities for testing LoopBack apps

Other

8 stars 20 forks source link

Assertion shouldBeAllowed is confusing #38

Open jrschumacher opened 9 years ago

jrschumacher commented 9 years ago

The assertion shouldBeAllowed is confusing. It says it should have a response 100-300, but to me this sounds more like the assertion should be named shouldBeNonError or something similar.

jrschumacher commented 9 years ago

https://github.com/strongloop/loopback-testing/blob/master/lib/helpers.js#L311-L318