strongloop-archive / loopback-testing

DEPRECATED Utilities for testing LoopBack apps
Other
8 stars 20 forks source link

use findorCreate to create roles #51

Closed ningsuhen closed 9 years ago

ningsuhen commented 9 years ago

The Role creation helper creates a new/duplicate role everytime even if it is of the same name. However, this is not very helpful. Role names should be unique. Also, in a system where there are pre-created roles like 'admin', I think that findOrCreate works better. Please merge this if you think this is a legit argument.

slnode commented 9 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

bajtos commented 9 years ago

@slnode ok to test

ritch commented 9 years ago

Thanks @ningsuhen