strongloop-community / loopback-sdk-android

Android Client SDK for the LoopBack framework.
Other
67 stars 41 forks source link

Model.toMap should include superClass properties #117

Open nikooiko opened 7 years ago

nikooiko commented 7 years ago

Bug or feature request

Description of feature (or steps to reproduce if bug)

Here is the actual call stack Model.toMap() > VirtualObject.toMap() > BeanUtil.getProperties(model, false, false);

BeanUtil.getProperties is called with hardcoded false (second param) that doesn't allow the model to include it's parent's properties.

I think that there should be a way to include model's parent properties when calling toMap(). For example if we define a model AppUser that extends User, appUser.save() (that internally calls Model.toMap) should include password property, defined at User class.

Current work around is to redefine the getters for the properties we want to include.

Link to sample repo to reproduce issue (if bug)

Expected result

If a model extends another model (eg AppUser that extends User) should probably include it's parents properties.

Actual result (if bug)

Only the model's properties.

Additional information (Node.js version, LoopBack version, etc)

LB Android SDK: 1.5.1