search

strongloop-community / loopback-sdk-ios

iOS Client SDK for the LoopBack framework.
Other
76 stars 39 forks source link

WIP: fix on new CI #108

Closed rmg closed 8 years ago

rmg commented 8 years ago

Not sure why, but this one test is failing under XCode 7.2.1 on CI.

rmg commented 8 years ago

@slnode test please

rmg commented 8 years ago

@hideya any ideas why this one test is failing when run under XCode 7? (7.2.1)

hideya commented 8 years ago

@rmg sorry for the delay in my response. On my local machine, all the tests pass under Xcode 7.2.1. The following shows the build env:

+ xcodebuild -version
Xcode 7.2.1
Build version 7C1002
+ xcodebuild -showsdks
OS X SDKs:
    OS X 10.11                      -sdk macosx10.11

iOS SDKs:
    iOS 9.2                         -sdk iphoneos9.2

iOS Simulator SDKs:
    Simulator - iOS 9.2             -sdk iphonesimulator9.2

tvOS SDKs:
    tvOS 9.1                        -sdk appletvos9.1

tvOS Simulator SDKs:
    Simulator - tvOS 9.1            -sdk appletvsimulator9.1

watchOS SDKs:
    watchOS 2.1                     -sdk watchos2.1

watchOS Simulator SDKs:
    Simulator - watchOS 2.1         -sdk watchsimulator2.1

I'll make another PR just to see how it fails on CI without your mod in this PR.

hideya commented 8 years ago

@rmg please check out my comment: https://github.com/strongloop/loopback-sdk-ios/pull/109#issuecomment-202004657

bajtos commented 8 years ago

While this change is hiding the fact that our implementation of Buffer may not work well across all platforms, I prefer to land it and get our CI green now.