search

strongloop-community / loopback-sdk-ios

iOS Client SDK for the LoopBack framework.
Other
76 stars 39 forks source link

SLObject's property attribute for repository shouldn't be "weak"? #98

Closed hideya closed 8 years ago

hideya commented 8 years ago

Currently SLObject's repository property has an attribute weak but it doesn't look correct -- otherwise we carefully retain a reference to the repository object, it can get niled out and server method invocation starts to fail (and I saw a few occasions that happens).

I thought that it was kept as weak to avoid any cyclic reference, but I don't see any such possibilities. I think it should have been strong.

hideya commented 8 years ago

I'm closing this as PR https://github.com/strongloop/loopback-sdk-ios/pull/100 is merged.