search

strongloop / gulp-loopback-sdk-angular

gulp plugin for auto-generating Angular $resource services for LoopBack
MIT License
27 stars 15 forks source link

changing test implementation to not base on size #11

Closed davidcheung closed 8 years ago

davidcheung commented 8 years ago

test checks file length, needs to match current master of loopback-sdk-angular

after short discussion with Ryan, changing approach to making this test case less maintenance required instead of just fixing the fixture.

Connected to strongloop/gulp-loopback-sdk-angular#12

davidcheung commented 8 years ago

@bajtos PATL, I will paste the convo from the issue here for better context

@davidcheung take a look at tests in loopback-angular-sdk-cli and grunt-loopback-angular-sdk. We need a simple smoke test to verify that the gulp plugin called the SDK codegen correctly, for example by checking few regular expressions (does the code contain the module name lbServices, etc.). There is no need to check file size.

I have also removed the manually updated lb-service.js completely as we don't need to use it anymore.

bajtos commented 8 years ago

LGTM. @davidcheung please squash the commits into a single one before landing this patch.