search

strongloop / gulp-loopback-sdk-angular

gulp plugin for auto-generating Angular $resource services for LoopBack
MIT License
27 stars 15 forks source link

Update loopback-sdk-angular to latest v1.4.0 #6

Closed alexthewilde closed 9 years ago

zmln commented 9 years ago

I can merge this but we may want to update the tests as well.

At the moment, the generated file is tested against a known working version that has been generated ahead of time. Feel free to change this up if it's not the best approach.

alexthewilde commented 9 years ago

@zimlin what exactly needs to be changed to get this PR merged? thanks

zmln commented 9 years ago

Update the tests

alexthewilde commented 9 years ago

Yeah I got that, but what exactly makes the tests fail?

zmln commented 9 years ago

Oh. Right now, it just checks against a per-generated file based off an empty app. The update probably generates a slightly different file.

Now that I'm thinking about it, I'm not entirely sure this is a great way to test it and if this even needs tests if loopback-sdk-angular is tested. I can probably just merge this in now.

alexthewilde commented 9 years ago

@zimlin that would be great if you merged this!

alexthewilde commented 9 years ago

@zimlin awesome. Are you also going to create a new npm release containing this change?