strongloop / loopback-boot

Convention-based bootstrapper for LoopBack applications
Other
62 stars 71 forks source link

update strong-globalize to 3.1.0 #269

Closed shimks closed 7 years ago

shimks commented 7 years ago

Testing whether the 2.x branch works with the latest version of strong-globalize

dhmlau commented 7 years ago

@bajtos, looks like we have errors in running node 0.10 and 0.12. I'd like to propose we update the debug version in strong-globalize in 2.x and make the 2.x loopback-* module using that version instead of strong-globalize 3.x. What do you think?

/home/jenkins/workspace/nb/loopback-boot~2.x/4b9e0b16/node_modules/strong-globalize/node_modules/os-locale/index.js:2
const execa = require('execa');
^^^^^
SyntaxError: Use of const in strict mode.
    at exports.runInThisContext (vm.js:73:16)
    at Module._compile (module.js:443:25)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
bajtos commented 7 years ago

Yeah, we will need to drop support for Node.js 0.x first, before this patch can be landed. See what I started in strong-remoting: https://github.com/strongloop/strong-remoting/pull/428

Alternatively, and I think this is actually a better option, we can fix strong-globalize's 2.x version line to ignore the Snyk vulnerability that's not affecting us and then publish a new version of strong-globalize. It may result in less work overall, because all dependents of strong-globalize@2 will start passing snyk/nsp checks with no modifications needed.

Thoughts?

dhmlau commented 7 years ago

sounds good to me.
@shimks, in this case, we'd need to add .nsprc file in strong-globalize 2.x, same as what we did in master. https://github.com/strongloop/strong-globalize/blob/master/.nsprc

bajtos commented 7 years ago

I opened #272 to remove support for Node.js 0.10 and 0.12 in our 2.x branch.

shimks commented 7 years ago

@slnode test please

shimks commented 7 years ago

@slnode test please

dhmlau commented 7 years ago

@shimks @bajtos , if this change is only needed for getting rid of the security vulnerability, this is no longer needed.