search

strongloop / loopback-component-explorer

Browse and test your LoopBack app's APIs
Other
71 stars 102 forks source link

update swagger-ui version #250

Closed dhmlau closed 5 years ago

dhmlau commented 5 years ago

Description

When running npm i in this module, I got the following warning:

npm WARN deprecated swagger-ui@2.2.10: No longer maintained, please upgrade to swagger-ui@3.

This PR will update swagger-ui version in package.json.

bajtos commented 5 years ago

Upgrading to swagger-ui@3 is a lot of effort. See https://github.com/strongloop/loopback-component-explorer/pull/209 for the previous attempt made by @STRML .

The following issue is the biggest blocker:

loopback-swagger need to produce auth metadata - see strongloop/loopback-swagger#65

The pull request also says:

The npm package no longer exports a bundle. I'm not sure if this is intentional. For this reason, I've added a dev-only script to copy from github releases.

I think this is no longer relevant, we are successfully using https://www.npmjs.com/package/swagger-ui-dist in LB4.

dhmlau commented 5 years ago

Based on @bajtos' above comment and https://github.com/strongloop/loopback-component-explorer/issues/254 is opened to investigate the work involved in upgrading swagger-ui version, I'm closing this PR.