search

strongloop / loopback-component-explorer

Browse and test your LoopBack app's APIs
Other
71 stars 102 forks source link

Prevent accidental upgrades to swagger-ui v3+ #255

Closed bajtos closed 5 years ago

bajtos commented 5 years ago

To prevent accidental upgrades to a new (and very incompatible) version of swagger-ui, I am proposing to add an explicit version check that will abort the test suite when upgrade is detected.

$ npm t

> loopback-component-explorer@6.3.1 test /Users/bajtos/src/loopback/component-explorer
> mocha

Upgrading from swagger-ui@2 to a newer major version is difficult, see
https://github.com/strongloop/loopback-component-explorer/issues/254
If you are confident about this change and have manually verified API Explorer
functionality in the browser, including access-token based authentication,
then you can delete this check.

npm ERR! Test failed.  See above for more details.

See #250, #253 and and #254.

bajtos commented 5 years ago

Waiting for https://github.com/strongloop/loopback-component-explorer/pull/257 to update eslint config to allow ES6 features.