Add globalization

[loay]

Connect to strongloop/loopback/issues/2422

[loay]

@superkhau @0candy PTAL

[jannyHou]

From CI it fails due to

 assert.js:86
  throw new assert.AssertionError({
        ^
AssertionError: *** setRootDir: Intl dir not found under: /mnt/jenkins/workspace/loopback-component-oauth2/6d9b883b/lib

It might be fixed by rerun slt-globalize -e and alt-globalize -l each time before you commit your change.

[Amir-61]

@loay

I had a quick review; I see lots of unrelated changes in this PR; please revert back unrelated changes like adding extra blank lines or removing blank lines,...

[rmg]

@slnode test please

[loay]

@superkhau @0candy PTAL again. Thanks.

[0candy]

@loay Please revert the debug statements.

[loay]

All Fixed. PTAL again Thanks @0candy

[Amir-61]

@loay Basically whatever should not be translated like variable names you should skip them by using brackets: Example:

{{foo}}

[0candy]

You should revert this file lib/models/index.js and test/middleware/authorization.test.js

[loay]

Done more fixes. @superkhau @0candy PTAL again

@superkhau there is no bikeshedding. I am just trying to understand the logic behind it since changes in this repo are over 400 changes and I didn't want to start over. By the same logic of translation, I have actually fixed around 15-20 more words that the review did not catch.

[superkhau]

@loay Sounds good, if you feel it is a valid concern, then we should get @Setogit to answer that question as he is the correct person to ask. Please update us/globalization.md with your findings so we don't all end up asking the same question again.

[jannyHou]

@loay left two comments, others LGTM 👍

[loay]

@jannyHou @0candy Fixed both issues and rebased. Thanks

[loay]

@superkhau concerning all the unrelated ones, when you add the globalization declaration on top of each file, it automatically deletes/adds a line. They actually cancel each other out, since it is -/+, but they are still there somehow. Anyways there is a linting PR ready to go once this one is merged.

[superkhau]

@loay Bunch of nitpicks, but otherwise LGTM. As for the unrelated changes, maybe you should submit a PR running eslint, get that merged in, then rebase this PR so all those other edits will dissappear. Anyways, it's not a big deal since I looked at those changes during this review and they're all whitespace anyways. I'll leave it up to your discretion for what to do from here. :ship:

[loay]

@superkhau Thanks. I know it was a long review :)