strongloop / loopback-component-oauth2

oAuth 2.0 server for LoopBack

http://www.strongloop.com

Other

62 stars 63 forks source link

Differentiate redirect uri to tell a failed login #59

Closed kenke7 closed 7 years ago

kenke7 commented 7 years ago

Description

There is no options passed in when authenticating with local strategy. A minimum-change solution is to append "?loginFailed" to the end of failureRedirect uri when login failed (and leave blank if it is a normal login.)

This did the same with #33 . Just hoping it get merged because it is really annoying.

Related issues

21

Checklist

[ ] New tests added or existing tests modified to cover all changes
[x] Code conforms with the style guide

slnode commented 7 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

slnode commented 7 years ago

Can one of the admins verify this patch?

slnode commented 7 years ago

Can one of the admins verify this patch?

slnode commented 7 years ago

Can one of the admins verify this patch?

stale[bot] commented 7 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 7 years ago

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.