search

strongloop / loopback-component-oauth2

oAuth 2.0 server for LoopBack
http://www.strongloop.com
Other
62 stars 63 forks source link

Tidy up validation of access tokens/authorization codes #8

Closed raymondfeng closed 9 years ago

raymondfeng commented 9 years ago

/to @bajtos or @ritch

The PR fixes issues discovered by https://github.com/strongloop/strong-gateway/issues/19.

bajtos commented 9 years ago

@raymondfeng Who is going to review this PR?

I don't see any tests, is it intentional?

bajtos commented 9 years ago

Assigned to myself, since I am an assignee for https://github.com/strongloop/loopback-component-oauth2/issues/3 too.

bajtos commented 9 years ago

I'll review this patch in more detail on Monday. I see there are some tests, although I am not sure they are covering all the changes made here.

@ritch if there is a chance you will have time to review this today, then feel free to take his over, so that @raymondfeng has a chance to update the PR before he leaves for his PTO.

raymondfeng commented 9 years ago

Please note changes in this PR are test-covered by https://github.com/strongloop/strong-gateway/pull/19

bajtos commented 9 years ago

See my comments above. I don't understand the code fully, I looked for obvious problems only.

bajtos commented 9 years ago

LGTM.