update eslint and fix violations

strongloop / loopback-component-oauth2

oAuth 2.0 server for LoopBack

http://www.strongloop.com

Other

62 stars 63 forks source link

update eslint and fix violations #86

Closed nabdelgadir closed 5 years ago

nabdelgadir commented 5 years ago

Related issues

connect to https://github.com/strongloop-internal/scrum-apex/issues/425

Checklist

[ ] New tests added or existing tests modified to cover all changes
[x] Code conforms with the style guide

nabdelgadir commented 5 years ago

CI is failing but it says No identified problem No problems were identified. If you know why this problem occurred, please add a suitable Cause for it. I don't believe it's related.

bajtos commented 5 years ago

The only change in question is whether we want to introduce package-lock.json.
@raymondfeng @bajtos, what's your thought on that? Thanks.

We are intentionally NOT USING package-lock files in LB3 repositories. I am open to discuss a switch to package locking, but not in this PR please.

Please remove package-lock.json file from the patch.

nabdelgadir commented 5 years ago

@bajtos @dhmlau I didn't mean to add the package-lock.jsons (to this one or other related PRs). They were being generated when I did npm i and I didn't notice them but I'll take them out of the PRs they're in. Thanks!