strongloop / loopback-component-passport

LoopBack passport integration to support third party logins and account linking
Other
139 stars 228 forks source link

Upd: saml: pass callbackURL as callbackUrl. [REBASED] #237

Closed cadesalaberry closed 6 years ago

cadesalaberry commented 6 years ago

Description

As specified in the passport-saml package, the callback URL should be passed as callbackUrl which is different from all passport strategies. To avoid such discrepancies, defaults the callbackUrl to the given callbackURL. In any case, it will not break compatibility as it will be overridden by callbackUrl if it is already specified.

callbackUrl: full callbackUrl (overrides path/protocol if supplied) path: path to callback; will be combined with protocol and server host information to construct callback url if callbackUrl is not specified (default: /saml/consume) protocol: protocol for callback; will be combined with path and server host information to construct callback url if callbackUrl is not specified (default: http://) host: host for callback; will be combined with path and protocol to construct callback url if callbackUrl is not specified (default: localhost)

Checklist

slnode commented 6 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

slnode commented 6 years ago

Can one of the admins verify this patch?

slnode commented 6 years ago

Can one of the admins verify this patch?

b-admike commented 6 years ago

@slnode test please

cadesalaberry commented 6 years ago

Thanks for the merge!

Cheers,