strongloop / loopback-component-passport

LoopBack passport integration to support third party logins and account linking
Other
139 stars 227 forks source link

add a configuration for cookieOptions #240

Closed peterwillis closed 6 years ago

peterwillis commented 6 years ago

Description

options.cookieOptions can either be a function or an object, the result is passed to res.cookie as the options argument.

Please advise the tests I should include, because I don't see any testing the existing configuration options for anything other than the ldap provider. I am happy to add something similar for the local login provider if somebody could help me with a minimal configuration and guidance of what other tests to add.

Checklist

slnode commented 6 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 6 years ago

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.