Missing loopback dependency

[jt-nti]

Description/Steps to reproduce

I think loopback should be in dependencies rather than devDependencies

Link to reproduction sandbox

const blah = require('loopback-component-passport');

console.log('Yay!');

Fails with Error: Cannot find module 'loopback' when loopback is in devDependencies but works as expected when it's in dependencies

Additional information

darwin x64 8.9.1

└── loopback-component-passport@3.4.1

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jt-nti]

I was a bit puzzled about the reasoning behind rejecting a pull request to fix this...

Thank you for the patch. But having loopback as dev dep is intentional. We expect the application that uses this component will have loopback declared as a dep.

...but on further investigation it sounds like there should be a peer dependency, as well as a dev dependency. I'll submit a new PR.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[jt-nti]

Waiting for review on PR #252

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.