handle azure-saml profile id

strongloop / loopback-component-passport

LoopBack passport integration to support third party logins and account linking

Other

139 stars 228 forks source link

handle azure-saml profile id #250

Closed GhizlaneA closed 6 years ago

GhizlaneA commented 6 years ago

Description

Related issues

connect to

Checklist

[ ] New tests added or existing tests modified to cover all changes
[ ] Code conforms with the style guide

Comment

I could not find a way to test it, because there are no available test for profile creation. The code added does not change the current behavior at all. But if tests are absolutely needed, can you please show me how to create one. Thank you.

slnode commented 6 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

jannyHou commented 6 years ago

@slnode test please

GhizlaneA commented 6 years ago

@jannyHou Thank you very much! it is now changed to simple quotes

jannyHou commented 6 years ago

@slnode test please

jannyHou commented 6 years ago

PR merged 🚢 , thank you again for the contribution! @GhizlaneA

GhizlaneA commented 6 years ago

@jannyHou Great!! thank you!