strongloop / loopback-component-passport

LoopBack passport integration to support third party logins and account linking
Other
139 stars 228 forks source link

Add failureError Option #251

Closed DerekTBrown closed 4 years ago

DerekTBrown commented 6 years ago
slnode commented 6 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

jannyHou commented 6 years ago

@slnode test please

dhmlau commented 6 years ago

@DerekTBrown, thanks for your PR. The CI failed because of some linting issue. Could you please fix it?

16:28:03 /home/jenkins/workspace/nb/loopback-component-passport~master/7a48ad0e/lib/passport-configurator.js
16:28:03   561:11  error  Expected space(s) after "if"        keyword-spacing
16:28:03   561:35  error  Missing space before opening brace  space-before-blocks
16:28:03   677:1   error  Trailing spaces not allowed         no-trailing-spaces
16:28:03   678:9   error  Expected space(s) after "if"        keyword-spacing
16:28:03   678:33  error  Missing space before opening brace  space-before-blocks

You can fix it by running this command:

./node_modules/.bin/eslint --fix .
dhmlau commented 6 years ago

@DerekTBrown, still interested in working on this PR?

jannyHou commented 6 years ago

@slnode test please

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.