Added support for custom strategy and attaching additional models to component.

[DOSarrest]

Description

Added support for custom strategy and attaching additional models to component.

Related issues

• connect to #263

Checklist

• [x] New tests added or existing tests modified to cover all changes
• [x] Code conforms with the style guide

[slnode]

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

[virkt25]

ok to test

[DOSarrest]

I see that there appear to be some failures now. Possibly related to tests, but I am not familiar with the testing platform used or the errors. Are you able to give me any details as to why it is failing?

[DOSarrest]

Examining the output I think I may have figured out the issue. It appears to be related to testing. Investigating now.

[DOSarrest]

I resolved the issues, but now it's failing on cis-jenkins. When clicking details it redirects to a site that times out, so I am unable to determine any other issues, if any exist. @virkt25 Is that to be expected?

[virkt25]

@DOSarrest IIRC cis-jenkins is behind a firewall so you won't be able to load it. That said, here's the relevant part of the logs that is causing the build to fail. Looks like some linting error. You should be able to reproduce this locally by running npm run lint.

18:13:35 > loopback-component-passport@3.10.0 lint /home/jenkins/workspace/nb/loopback-component-passport~master/7a48ad0e
18:13:35 > eslint .
18:13:35 
18:13:38 
18:13:38 /home/jenkins/workspace/nb/loopback-component-passport~master/7a48ad0e/lib/index.js
18:13:38   27:41  error  Expected a newline before ')'  function-paren-newline
18:13:38   31:22  error  Expected a newline before ')'  function-paren-newline
18:13:38   33:29  error  Expected a newline before ')'  function-paren-newline
18:13:38 
18:13:38 /home/jenkins/workspace/nb/loopback-component-passport~master/7a48ad0e/lib/passport-configurator.js
18:13:38   145:70  error  Expected a newline before ')'  function-paren-newline
18:13:38   176:66  error  Expected a newline before ')'  function-paren-newline
18:13:38   334:7   error  Unexpected newline before ')'  function-paren-newline
18:13:38   417:7   error  Unexpected newline before ')'  function-paren-newline
18:13:38   433:70  error  Expected a newline before ')'  function-paren-newline
18:13:38   445:7   error  Unexpected newline before ')'  function-paren-newline
18:13:38   459:54  error  Expected a newline before ')'  function-paren-newline
18:13:38   468:7   error  Unexpected newline before ')'  function-paren-newline
18:13:38   489:31  error  Expected a newline before ')'  function-paren-newline
18:13:38   499:7   error  Unexpected newline before ')'  function-paren-newline
18:13:38   526:7   error  Unexpected newline before ')'  function-paren-newline
18:13:38   548:31  error  Expected a newline before ')'  function-paren-newline
18:13:38   558:7   error  Unexpected newline before ')'  function-paren-newline
18:13:38   643:30  error  Expected a newline before ')'  function-paren-newline
18:13:38 
18:13:38 ✖ 17 problems (17 errors, 0 warnings)
18:13:38   17 errors, 0 warnings potentially fixable with the `--fix` option.

[DOSarrest]

@virkt25 I just went through each line based on your supplied output, and none of those lines was touched by me or the patches that are part of this PR. Some of those errors are even in lib/index.js which is not part of this PR either.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale[bot]]

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.