Add FCM support with addNotification in node-gcm 1.4.4

strongloop / loopback-component-push

Push notification component for LoopBack.

http://loopback.io/doc/en/lb2/Push-notifications.html

Other

96 stars 95 forks source link

Add FCM support with addNotification in node-gcm 1.4.4 #146

Closed zbarbuto closed 7 years ago

zbarbuto commented 7 years ago

Description

Notifications aren't sent to the new FCM system with the latest version of node-gcm. This uses the addNotification() method to add the expected notification properties to the message to be sent.

The properties used are messageFrom for the title and alert for the body as this makes it fully compatible with the existing docs on notifications (ie. the result on the device will be the same on both iOS and Android)

Related issues

None

Checklist

[x] New tests added or existing tests modified to cover all changes
[x] Code conforms with the style guide

slnode commented 7 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

slnode commented 7 years ago

Can one of the admins verify this patch?

slnode commented 7 years ago

Can one of the admins verify this patch?

slnode commented 7 years ago

Can one of the admins verify this patch?

zbarbuto commented 7 years ago

Added tests to prevent regressions as per request in #141. cc @superkhau

superkhau commented 7 years ago

@zbarbuto TY for following up with a test to prevent regressions. :+1:

superkhau commented 7 years ago

@slnode test please

zbarbuto commented 7 years ago

@superkhau Anything else I can do to help get this merged? Does someone else need to review?

superkhau commented 7 years ago

@zbarbuto Nope, it's LGTM now. TY for the contribution. ;)