strongloop / loopback-component-push

Push notification component for LoopBack.
http://loopback.io/doc/en/lb2/Push-notifications.html
Other
96 stars 94 forks source link

Add support for data-only notifications #166

Closed zbarbuto closed 6 years ago

zbarbuto commented 6 years ago

Description

Adds a 'dataOnly' key which allows creating android notifications using only data properties instead of notification properties.

The specific use-case here is allowing "data-only" notification payloads as "notification" do not forward the data:

https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/PAYLOAD.md#notification-vs-data-payloads

Related issues

Checklist

Note, I avoided the ES6 syntax as the lint file still specifies ES5 only

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

zbarbuto commented 6 years ago

Not stale - still waiting for review...

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

zbarbuto commented 6 years ago

Not stale - still waiting for review...

dhmlau commented 6 years ago

@strongloop/lb-next-dev , PTAL.

bajtos commented 6 years ago

@zbarbuto thank you for the pull request and sorry for keeping you waiting for so long. We are not closely watching this repository these day, since most of our effort goes to LoopBack 4.