Update doc for .uploadstream and .downloadstream

strongloop / loopback-component-storage

Storage component for LoopBack.

Other

130 stars 155 forks source link

Closed wolrajhti closed 6 years ago

wolrajhti commented 6 years ago

It seems that the documentation is not matching functions prototypes

Callbacks are never called. Should use Stream Event: 'finish' instead. Documentation is misguiding.

slnode commented 6 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

wolrajhti commented 6 years ago

sry for this duplicate PR. Same idea at the same time, what a magic moment ><

dhmlau commented 6 years ago

Indeed. Thanks for the contribution anyway!