search

strongloop / loopback-component-storage

Storage component for LoopBack.
Other
130 stars 155 forks source link

Upgrade pkgcloud version #276

Closed diegoazh closed 5 years ago

diegoazh commented 5 years ago

Description

This upgrade fix the bug in uploading files to google cloud storage.

Related issues

Upload method never calls the callback function: #273

Checklist

slnode commented 5 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

dhmlau commented 5 years ago

@slnode test please

dhmlau commented 5 years ago

@diegoazh, thanks for your contribution. Your PR has landed! 🎉

diegoazh commented 5 years ago

When you think this change will be released?

dhmlau commented 5 years ago

@diegoazh, we're in the process of getting other community PRs to land before the release. See if we can do it by end of this week, if not, I can release it on Friday anyway. Thanks!

dhmlau commented 5 years ago

@diegoazh, thanks for taking up the 2 stale PRs. :)
It probably needs to take some more time to get those to merge, so I made a new release of this module that contains the changes in this PR. Thanks!

diegoazh commented 5 years ago

Thank you @dhmlau