strongloop / loopback-example-access-control

An example demonstrating LoopBack access control mechanisms.
Other
370 stars 168 forks source link

Refactor `user` to another name #73

Open superkhau opened 8 years ago

superkhau commented 8 years ago

We get a lot of confusion from my original implementation of user extending builtin User. We should rename it to something like CustomUser or something to signify it's obviously not the same as builtin User.

timotheemoulin commented 8 years ago

Thanks for reporting that ;)

The official documentation tells us to use Customer or Client when overriding the User model. Moreover, I am not conviced that mixing naming conventions in the example is a good practice.

https://docs.strongloop.com/display/public/LB/Managing+users

superkhau commented 8 years ago

Do you have any suggestions? :ear:

timotheemoulin commented 8 years ago

I think that using the same names as in the official documentation Customer, Client would be a good idea. I might highy help people understanding the examples.

superkhau commented 8 years ago

Haha, actually user was the official name before and we added Customer/Client because we had to keep explaining it before, but never got around to updating the examples to match. ;) I think we'll go with Customer because Client will probably cause other issues down the line. Thanks for the feedback.

timotheemoulin commented 8 years ago

Ok I get it.

I don't mind using User twice. That's even what I would have done if not told otherwise in the doc. What bother me more is that it's once written in lowercase and the second time with an uppercase U

superkhau commented 8 years ago

No, it has to be lowercase or it will conflict with the builtin User model. That or you can name it something other than "User".

DaGaMs commented 8 years ago

the User vs user issue also breaks down if you use mysql as a backend, since it can't distinguish between tables by case.

antarasi commented 7 years ago

Account seems to be distinguishable enough and independent from actual user purpose (Client, Customer etc)

superkhau commented 7 years ago

Would someone like to submit a PR? I can help with the landing. ;)

csakis commented 6 years ago

I addressed this issue in a new PR