strongloop / loopback-example-access-control

An example demonstrating LoopBack access control mechanisms.
Other
370 stars 168 forks source link

User - Team relation definition is misleading #87

Closed antarasi closed 7 years ago

antarasi commented 7 years ago

As the Team entity has only ownerId and memberId properties (only foreign keys), it is impossible to the User to have more than one Team. So User has many teamMembers, not many Teams.

Current definition can lead to misunderstanding of Role Resolver that finds teams where

I propose to change it to make people better understand the logic behind that. Code related to that relation needs to be updated too.

slnode commented 7 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

stale[bot] commented 7 years ago

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.