strongloop / modern-syslog

modern-syslog
Other
49 stars 19 forks source link

add node 6 to testing #16

Closed msimerson closed 8 years ago

msimerson commented 8 years ago

I use modern-syslog in an application and it works just fine in node 0.10, 4, and 5 but fails under node 6. While attempting to use modern-syslog I'm getting TypeError: undefined is not a function errors.

slnode commented 8 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

slnode commented 8 years ago

Can one of the admins verify this patch?

msimerson commented 8 years ago

And yay, Travis also sees the issue (it's reproducible):

TypeError: undefined is not a function
test/test-compat.js ................................... 8/9
  not ok test/test-compat.js
    timeout: 30000
    file: test/test-compat.js
    results:
      ok: false
      count: 1
      pass: 1
      plan:
        start: 1
        end: 1
    exitCode: 1
    command: /home/travis/.nvm/versions/node/v6.3.0/bin/node
    arguments:
      - test/test-compat.js
test/test-core.js ................................... 18/18
June[3465]: Hi, June
Leonie: Hi, Leonie
undefined:0
TypeError: undefined is not a function
test/test-openlog.js .................................. 1/2
  not ok test/test-openlog.js
sam-github commented 8 years ago

Thanks @msimerson, rather than getting you to rebase, I closed with PR #18. Should be working on node 6 now.

msimerson commented 8 years ago

Thanks @sam-github !

msimerson commented 8 years ago

Any eta when at new version will get released?

rmg commented 7 years ago

@msimerson in case you missed it, v1.1.4 On Sept. 30 and includes the changes you were looking for.

msimerson commented 7 years ago

Got 'em @rmg, thanks!