search

strongloop / modern-syslog

modern-syslog
Other
49 stars 19 forks source link

update to nan2 #3

Closed sam-github closed 9 years ago

sam-github commented 9 years ago

connected to strongloop-internal/scrum-nodeops#893

rmg commented 9 years ago

If #4 can get merged before this is will make CI useable for this PR

rmg commented 9 years ago

@slnode test please

sam-github commented 9 years ago

are you sure about the removal of per/method scopes? Other than that, LGTM

rmg commented 9 years ago

@bnoordhuis are you able to give this a once over? You're far more familiar with this stuff than I am and I'd like a second opinion on the scope question.

bnoordhuis commented 9 years ago

Suggestions but basically LGTM.

rmg commented 9 years ago

@slnode test please