bump dependency versions - esp. nan to 2.13.2

strongloop / modern-syslog

modern-syslog

Other

49 stars 19 forks source link

bump dependency versions - esp. nan to 2.13.2 #31

Closed msimerson closed 5 years ago

msimerson commented 5 years ago

so there's a chance of compiling successfully on node 12.

slnode commented 5 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

raymondfeng commented 5 years ago

@msimerson If you upgrade deps to latest version, we can probably make a new major release.

msimerson commented 5 years ago

A new release will likely be warranted but my intentions are to get syslog working with node 12, so this PR will go hand-in-glove with #32. This PR was mainly about getting nan updated, and is likely going to be a pre-req for #32.

raymondfeng commented 5 years ago

Please squash all commits into one.

msimerson commented 5 years ago

I shall, once I have a PR that is merge-ready. (waiting on CI test results)

msimerson commented 5 years ago

This PR is complete and IMO, can be merged. It's positive effect is to reduce the number of security vulnerabilities installed by the dev dependencies.

sam-github commented 5 years ago

I still get a bunch of compiler errors and a build failure under node 12. I'm over my head and don't know the solution.

I am working on porting to 12.x.

sam-github commented 5 years ago

This is semver-major and doesn't support 12.x, it is replaced with #35 (12.x support) and #36 (bump dep versions)

msimerson commented 5 years ago

So, I create a PR, read through the changelogs for the deps to determine which are safe to update to, do test builds against them, and then you replace the PR with another and steal the credit. Not very friendly.

msimerson commented 5 years ago

FWIW, this PR isn't semver-major. I limited the dep version updates to those that included support for all the versions of node that this package presently supports.