search

strongloop / modern-syslog

modern-syslog
Other
49 stars 19 forks source link

add node 8, 10, and 12 CI testing #32

Closed msimerson closed 5 years ago

slnode commented 5 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

sam-github commented 5 years ago

ok to test

msimerson commented 5 years ago

This PR is ready. It drops node 5 CI testing and adds testing for node 8, 10, and 12. It doesn't require 12.x tests to pass, because they don't. I've opened #34 for that.

sam-github commented 5 years ago

Other than the fast_finish this is replaced by #35. I don't think we need fast_finish, because with #35 and #36 no platforms are allowed to fail. I can reopen this (or add fast_finish to the others) if I misunderstand.