Perhaps this issue will fix itself with a new version of nan. If so, should the version specified in package.json be updated to that new version?
> modern-syslog@1.1.4 install /home/travis/build/strongloop/modern-syslog
> node-gyp rebuild
make: Entering directory `/home/travis/build/strongloop/modern-syslog/build'
CXX(target) Release/obj.target/core/core.o
../core.cc:7:11: error: ‘v8::Handle’ has not been declared
using v8::Handle;
^
../core.cc: In member function ‘virtual void {anonymous}::Worker::HandleOKCallback()’:
../core.cc:34:39: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated (declared at ../node_modules/nan/nan.h:1674) [-Wdeprecated-declarations]
callback->Call(0, NULL);
^
../core.cc: In function ‘Nan::NAN_METHOD_RETURN_TYPE {anonymous}::OpenLog(Nan::NAN_METHOD_ARGS_TYPE)’:
../core.cc:49:23: error: no matching function for call to ‘v8::Value::ToString()’
info[0]->ToString()->WriteUtf8(ident, sizeof(ident)-1);
^
../core.cc:49:23: note: candidates are:
In file included from /home/travis/.node-gyp/12.1.0/include/node/node.h:63:0,
from ../core.cc:1:
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2528:44: note: v8::MaybeLocal<v8::String> v8::Value::ToString(v8::Local<v8::Context>) const
V8_WARN_UNUSED_RESULT MaybeLocal<String> ToString(
^
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2528:44: note: candidate expects 1 argument, 0 provided
In file included from /home/travis/.node-gyp/12.1.0/include/node/v8-internal.h:14:0,
from /home/travis/.node-gyp/12.1.0/include/node/v8.h:25,
from /home/travis/.node-gyp/12.1.0/include/node/node.h:63,
from ../core.cc:1:
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2544:35: note: v8::Local<v8::String> v8::Value::ToString(v8::Isolate*) const
Local<String> ToString(Isolate* isolate) const);
^
/home/travis/.node-gyp/12.1.0/include/node/v8config.h:322:3: note: in definition of macro ‘V8_DEPRECATE_SOON’
declarator __attribute__((deprecated(message)))
^
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2544:35: note: candidate expects 1 argument, 0 provided
Local<String> ToString(Isolate* isolate) const);
^
/home/travis/.node-gyp/12.1.0/include/node/v8config.h:322:3: note: in definition of macro ‘V8_DEPRECATE_SOON’
declarator __attribute__((deprecated(message)))
^
../core.cc:50:38: error: no matching function for call to ‘v8::Value::Int32Value()’
int option = info[1]->Int32Value();
^
../core.cc:50:38: note: candidate is:
In file included from /home/travis/.node-gyp/12.1.0/include/node/node.h:63:0,
from ../core.cc:1:
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2569:40: note: v8::Maybe<int> v8::Value::Int32Value(v8::Local<v8::Context>) const
V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
^
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2569:40: note: candidate expects 1 argument, 0 provided
../core.cc:51:40: error: no matching function for call to ‘v8::Value::Int32Value()’
int facility = info[2]->Int32Value();
^
../core.cc:51:40: note: candidate is:
In file included from /home/travis/.node-gyp/12.1.0/include/node/node.h:63:0,
from ../core.cc:1:
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2569:40: note: v8::Maybe<int> v8::Value::Int32Value(v8::Local<v8::Context>) const
V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
^
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2569:40: note: candidate expects 1 argument, 0 provided
../core.cc: At global scope:
../core.cc:58:27: error: ‘Handle’ does not name a type
static char* dupBuf(const Handle<Value>& arg) {
^
../core.cc:58:27: error: ISO C++ forbids declaration of ‘parameter’ with no type [-fpermissive]
../core.cc:58:33: error: expected ‘,’ or ‘...’ before ‘<’ token
static char* dupBuf(const Handle<Value>& arg) {
^
../core.cc: In function ‘char* {anonymous}::dupBuf(int)’:
../core.cc:59:42: error: ‘arg’ was not declared in this scope
const char* mem = node::Buffer::Data(arg);
^
../core.cc: In function ‘char* {anonymous}::dupStr(const v8::Local<v8::String>&)’:
../core.cc:74:19: error: no matching function for call to ‘v8::String::WriteUtf8(char*&)’
m->WriteUtf8(s);
^
../core.cc:74:19: note: candidate is:
In file included from /home/travis/.node-gyp/12.1.0/include/node/node.h:63:0,
from ../core.cc:1:
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2738:7: note: int v8::String::WriteUtf8(v8::Isolate*, char*, int, int*, int) const
int WriteUtf8(Isolate* isolate, char* buffer, int length = -1,
^
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2738:7: note: candidate expects 5 arguments, 1 provided
../core.cc: In function ‘Nan::NAN_METHOD_RETURN_TYPE {anonymous}::SysLog(Nan::NAN_METHOD_ARGS_TYPE)’:
../core.cc:81:40: error: no matching function for call to ‘v8::Value::Int32Value()’
int priority = info[0]->Int32Value();
^
../core.cc:81:40: note: candidate is:
In file included from /home/travis/.node-gyp/12.1.0/include/node/node.h:63:0,
from ../core.cc:1:
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2569:40: note: v8::Maybe<int> v8::Value::Int32Value(v8::Local<v8::Context>) const
V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
^
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2569:40: note: candidate expects 1 argument, 0 provided
../core.cc:89:33: error: cannot convert ‘v8::Local<v8::Value>’ to ‘int’ for argument ‘1’ to ‘char* {anonymous}::dupBuf(int)’
message = dupBuf(info[1]);
^
../core.cc:91:44: error: no matching function for call to ‘v8::Value::ToString()’
message = dupStr(info[1]->ToString());
^
../core.cc:91:44: note: candidates are:
In file included from /home/travis/.node-gyp/12.1.0/include/node/node.h:63:0,
from ../core.cc:1:
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2528:44: note: v8::MaybeLocal<v8::String> v8::Value::ToString(v8::Local<v8::Context>) const
V8_WARN_UNUSED_RESULT MaybeLocal<String> ToString(
^
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2528:44: note: candidate expects 1 argument, 0 provided
In file included from /home/travis/.node-gyp/12.1.0/include/node/v8-internal.h:14:0,
from /home/travis/.node-gyp/12.1.0/include/node/v8.h:25,
from /home/travis/.node-gyp/12.1.0/include/node/node.h:63,
from ../core.cc:1:
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2544:35: note: v8::Local<v8::String> v8::Value::ToString(v8::Isolate*) const
Local<String> ToString(Isolate* isolate) const);
^
/home/travis/.node-gyp/12.1.0/include/node/v8config.h:322:3: note: in definition of macro ‘V8_DEPRECATE_SOON’
declarator __attribute__((deprecated(message)))
^
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2544:35: note: candidate expects 1 argument, 0 provided
Local<String> ToString(Isolate* isolate) const);
^
/home/travis/.node-gyp/12.1.0/include/node/v8config.h:322:3: note: in definition of macro ‘V8_DEPRECATE_SOON’
declarator __attribute__((deprecated(message)))
^
../core.cc:97:31: warning: ‘v8::Local<v8::Value> Nan::Callback::Call(int, v8::Local<v8::Value>*) const’ is deprecated (declared at ../node_modules/nan/nan.h:1674) [-Wdeprecated-declarations]
callback->Call(0, NULL);
^
../core.cc: In function ‘Nan::NAN_METHOD_RETURN_TYPE {anonymous}::SetLogMask(Nan::NAN_METHOD_ARGS_TYPE)’:
../core.cc:107:36: error: no matching function for call to ‘v8::Value::Int32Value()’
int mask = info[0]->Int32Value();
^
../core.cc:107:36: note: candidate is:
In file included from /home/travis/.node-gyp/12.1.0/include/node/node.h:63:0,
from ../core.cc:1:
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2569:40: note: v8::Maybe<int> v8::Value::Int32Value(v8::Local<v8::Context>) const
V8_WARN_UNUSED_RESULT Maybe<int32_t> Int32Value(Local<Context> context) const;
^
/home/travis/.node-gyp/12.1.0/include/node/v8.h:2569:40: note: candidate expects 1 argument, 0 provided
make: *** [Release/obj.target/core/core.o] Error 1
make: Leaving directory `/home/travis/build/strongloop/modern-syslog/build'
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.onExit (/home/travis/.nvm/versions/node/v12.1.0/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack at ChildProcess.emit (events.js:196:13)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:256:12)
gyp ERR! System Linux 4.4.0-101-generic
gyp ERR! command "/home/travis/.nvm/versions/node/v12.1.0/bin/node" "/home/travis/.nvm/versions/node/v12.1.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/travis/build/strongloop/modern-syslog
gyp ERR! node -v v12.1.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! modern-syslog@1.1.4 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the modern-syslog@1.1.4 install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /home/travis/.npm/_logs/2019-05-02T21_59_31_894Z-debug.log
The command "eval npm install " failed. Retrying, 2 of 3.
See failing Travis CI test.
Perhaps this issue will fix itself with a new version of
nan. If so, should the version specified inpackage.jsonbe updated to that new version?