search

strongloop / modern-syslog

modern-syslog
Other
49 stars 19 forks source link

supports iojs 3? #7

Closed Dexus closed 9 years ago

Dexus commented 9 years ago

I get build fails with 3.2.0 and 3.3.0...

rmg commented 9 years ago

@Dexus what errors are you seeing? It is building fine for me on OS X and on Linux under our CI.

Dexus commented 9 years ago

see https://travis-ci.org/Dexus/Haraka/jobs/78639406

rmg commented 9 years ago

The version of gcc in that build is 4.6, but the version of v8 that is used in iojs-3+ requires gcc-4.8 or newer due to the use of C++11 features.

Example: https://github.com/nodejs/nan/commit/05ed3b67d9e755592f696b4a41542657a90ab4b2

rmg commented 9 years ago

See 57fe2ac for a less noisy example than nan itself.

Dexus commented 9 years ago

:+1: perfect thank you for your fast clearing of the problem :)