search

strongloop / strong-agent

Profile, control, and monitor Node.js processes and clusters
http://strongloop.com/node-js/devops-tools/
Other
62 stars 9 forks source link

Made changes to ensure "npm test" passes on ppc64le arch #8

Closed ghatwala closed 9 years ago

ghatwala commented 9 years ago

While performing "npm test" on a "ppc" architecture, test case pertaining to "watchdog profiling" were failing. The failure was due to the fact that watchdog profiling was not supported on ppc64le arch . Made changes to ensure that those test cases are tested only on x64/32 arch type.

bnoordhuis commented 9 years ago

Thanks, but we don't take pull requests. I landed the changes recently in our private repository, they'll be in the next release.

ghatwala commented 9 years ago

Hi @bnoordhuis , Thanks for your quick reply. You mentioned above that you'll don't accept "pull" requests . If that is so , could you please just answer my few queries

  1. How do you'll accept code changes to this repo for any bug fixes ?
  2. Wanted to know if you have merged my changes done above in your private repo which you will be adding to your future release ?

Regards, Amit

bnoordhuis commented 9 years ago

How do you'll accept code changes to this repo for any bug fixes ?

From external developers we don't. strong-agent is a proprietary product, the legalities of accepting external contributions gets icky fast. Bug reports and feature requests are welcome, we just can't take actual code changes.

Wanted to know if you have merged my changes done above in your private repo which you will be adding to your future release ?

If you mean the diff I posted in https://github.com/strongloop/strong-agent/issues/7 a few days ago, yes, that's in our private repository and scheduled for the next patch release.

ghatwala commented 9 years ago

@bnoordhuis , thanks for your reply !!!

1) From external developers we don't. strong-agent is a proprietary product, the legalities of accepting external contributions gets icky fast. Bug reports and feature requests are welcome, we just can't take actual code changes. ---- Acknowledged.

2) If you mean the diff I posted in #7 a few days ago, yes, that's in our private repository and scheduled for the next patch release. --- Yes, was referring to the same which i had pointed out whilst building it on POWER architecture at my end .