Open seanbrookes opened 9 years ago
At the very least we should be checking if it has any spaces in it.
Additionally we should confirm that it only contains valid characters. (use the same rules as Model and Datasource name field?)
On Thu, Feb 26, 2015 at 10:18 AM, Chandrika Gole notifications@github.com wrote:
@sean https://github.com/sean, what kind of validation do we have for the host now?
— Reply to this email directly or view it on GitHub https://github.com/strongloop/strong-arc/issues/1044#issuecomment-76233761 .
StrongLoop http://strongloop.com/* makes it easy to develop APIs http://strongloop.com/mobile-application-development/loopback/ in Node, plus get DevOps capabilities http://strongloop.com/node-js-performance/strongops/ like monitoring, debugging and clustering*.
@sean dont see this on master. I was able to enter a host name with spaces
strongloop v2.10.14 (node v0.11.16) ├── strong-arc@1.1.32 (83151bb)
@sean for details.
Needs more work and have to move back.
The requirements were not very clear on this one apparently. The host value should be validated against the same rules as the Model and Datasource name fields (no spaces or wierd characters)
assigning to Chanda for priority and assignment
@JISOOLEE can you verify this please?
It seems not to be resolved yet. (Cannot see any error message when I save the host name including space or special characters)
@sean, what kind of validation do we have for the host now?