strongloop / strong-arc

StrongLoop Arc has been replaced by API Connect. We recommend Arc users move to the Essentials edition of API Connect. If you have questions, please email reachsl@us.ibm.com.
http://strongloop.com/
Other
114 stars 36 forks source link

Process Manager: Validation isn’t working for the host field #1044

Open seanbrookes opened 9 years ago

cgole commented 9 years ago

@sean, what kind of validation do we have for the host now?

seanbrookes commented 9 years ago

At the very least we should be checking if it has any spaces in it.

Additionally we should confirm that it only contains valid characters. (use the same rules as Model and Datasource name field?)

On Thu, Feb 26, 2015 at 10:18 AM, Chandrika Gole notifications@github.com wrote:

@sean https://github.com/sean, what kind of validation do we have for the host now?

— Reply to this email directly or view it on GitHub https://github.com/strongloop/strong-arc/issues/1044#issuecomment-76233761 .

StrongLoop http://strongloop.com/* makes it easy to develop APIs http://strongloop.com/mobile-application-development/loopback/ in Node, plus get DevOps capabilities http://strongloop.com/node-js-performance/strongops/ like monitoring, debugging and clustering*.

cgole commented 9 years ago

@sean dont see this on master. I was able to enter a host name with spaces

cgole commented 9 years ago

strongloop v2.10.14 (node v0.11.16) ├── strong-arc@1.1.32 (83151bb)

chandadharap commented 9 years ago

@sean for details.

chandadharap commented 9 years ago

Needs more work and have to move back.

seanbrookes commented 9 years ago

The requirements were not very clear on this one apparently. The host value should be validated against the same rules as the Model and Datasource name fields (no spaces or wierd characters)

seanbrookes commented 9 years ago

assigning to Chanda for priority and assignment

cgole commented 8 years ago

@JISOOLEE can you verify this please?

jisoolee commented 8 years ago

It seems not to be resolved yet. (Cannot see any error message when I save the host name including space or special characters)