Polishing VD: Process Manager: env get/set VD review

[altsang]

@stacy-hunt the env get/set has been implemented, I think there's some alignment issues, but you should review

[altsang]

VD: https://drive.google.com/drive/folders/0B1FTzkB7697GYm9HdVNxOFIzVzg/0B1FTzkB7697GUTBfbWpOak5HcGc/0B1FTzkB7697GOFhvSGgzb2Rickk/0B1FTzkB7697GZ3duVXdRVWFmVkE/0B1FTzkB7697GWk9pYnNpQ05kcVk/0B1FTzkB7697GQmxJZ0xoOW9qZUk/0B1FTzkB7697GRkJUVTg2UGc2WTQ slides, 21, 22

[stacy-hunt]

• The header and footer should not scroll, only the table should scroll
• The dialog can grow larger than the screen if many variables are added. I think we should consider putting a vertical limit on its size, at which time the scroll bar should appear. Or make the dialog a fixed size.
• Too much horizontal padding between the table and scrollbar (compare it to the VD)
• Cancel and Save buttons should right align with the border of the table
• After clicking “Add variable”, the “variable name” field should have focus ready to type
• The style of the borderless button isn't quite right (see comp, should this be fixed in a separate card?)
• The vertical spacing between the top of the dialog and the header, and the header and the table are too small (compare it to the comp)
• The header text is too small, should be Helvetica 18pt #4b4a4b
• It's possible to get the dialog into a state with excess padding at the bottom

[jtary]

The padding on the right of the table is the what is required to accommodate the delete button. This is also why the buttons are not aligned with the right side of the table; they are aligned with the right side of the table, you just can't see the part of the table that has the delete buttons.

I can reduce the padding on the delete buttons cell, which will make the spacing a bit smaller -- but there is still going to be excessive space on that side of the table. Similarly I can add padding to push the buttons so they align with the visible part of the table, but it does look a little odd. I'll leave that decision up to you, but we should standardize on how we want to align to the right side of tables with context-visible actions.

For the title and button, can we get proper cards to update the styleguide for these? The title should be one of the defined heading styles, and the borderless button needs to be updated both here and in the style guide.

I'll work on fixes the focus, scrolling and magic-expanding-dialog issue was part of this card.

[stacy-hunt]

Hey Joe, we probably need to do a call to discuss this stuff. Al's bumped API usage to the top of my priority list so how much time do you have left to tidy these things up before releasing? Can we defer till Mon?

On 8 April 2015 at 06:36, Joseph Tary notifications@github.com wrote:

The padding on the right of the table is the what is required to accommodate the delete button. This is also why the buttons are not aligned with the right side of the table; they are aligned with the right side of the table, you just can't see the part of the table that has the delete buttons.

I can reduce the padding on the delete buttons cell, which will make the spacing a bit smaller -- but there is still going to be excessive space on that side of the table. Similarly I can add padding to push the buttons so they align with the visible part of the table, but it does look a little odd. I'll leave that decision up to you, but we should standardize on how we want to align to the right side of tables with context-visible actions.

For the title and button, can we get proper cards to update the styleguide for these? The title should be one of the defined heading styles, and the borderless button needs to be updated both here and in the style guide.

I'll work on fixes the focus, scrolling and magic-expanding-dialog issue was part of this card.

— Reply to this email directly or view it on GitHub https://github.com/strongloop/strong-arc/issues/1157#issuecomment-90692850 .