strongloop / strong-arc

StrongLoop Arc has been replaced by API Connect. We recommend Arc users move to the Essentials edition of API Connect. If you have questions, please email reachsl@us.ibm.com.
http://strongloop.com/
Other
114 stars 36 forks source link

Data points box is always at the bottom of the screen #939

Open cgole opened 9 years ago

cgole commented 9 years ago

In the screen shot below, I am pointing my mouse at one of the data point in the green line for DB counters, but the box is always at the bottom of the screen screen shot 2015-01-30 at 5 00 13 pm

seanbrookes commented 9 years ago

should be a pretty simple CSS fix, just a matter of priority and time

anthonyettinger commented 9 years ago

I looked into this, the problem seems to stem from putting the charts inside a scrollable div.

The nvd3 library calculates the position based on window and uses the window scroll offset. But doesn't take into account the scrollable div offset.

We would have to either patch the nvd3 library to work with our scrollable div (not recommended). Or fix our layout such that the scrollbar on pages is on the window, not on a child div.

I filed a ticket with nvd3 to see if they have a workaround: https://github.com/novus/nvd3/issues/815

anthonyettinger commented 9 years ago

There's another ticket for this issue already: https://github.com/novus/nvd3/pull/460

chandadharap commented 9 years ago

Leave for now, revisit.

cgole commented 9 years ago

not a bug

cgole commented 9 years ago

This is still a problem.

anthonyettinger commented 9 years ago

upstream repo has a fix for this. We should only have to update our package.

https://github.com/novus/nvd3/pull/460

anthonyettinger commented 9 years ago

@cgole can you still reproduce?

cgole commented 9 years ago

I could still repro this. The data points box is not where it should it.

anthonyettinger commented 9 years ago

I upgraded the library, but there is new problem associated with d3 tip that is blocking us:

https://github.com/krispo/angular-nvd3/issues/102

anthonyettinger commented 9 years ago

verify fix from upstream is in place

anthonyettinger commented 9 years ago

there was a pending PR to fix this issue upstream, but the PR got rejected. It doesn't look promising as far as getting an upstream fix.

https://github.com/novus/nvd3/pull/851#issuecomment-139035710

RenatoUtsch commented 9 years ago

Not rejected, just taking a lot of time to be accepted.

RenatoUtsch commented 9 years ago

It seems that finally the PR was accepted. Could you guys test this and see if the problem is fixed?

anthonyettinger commented 9 years ago

I cannot figure out how to leverage this new option.

RenatoUtsch commented 9 years ago

What option are you talking about?

Em ter, 15 de set de 2015 22:40, Anthony Ettinger notifications@github.com escreveu:

I cannot figure out how to leverage this new option.

— Reply to this email directly or view it on GitHub https://github.com/strongloop/strong-arc/issues/939#issuecomment-140595409 .

anthonyettinger commented 9 years ago


{ tooltip: { chartContainer: '#my-chart' }}

Doens't seem to work```
RenatoUtsch commented 9 years ago

I am talking about the tooltip going to the bottom of the screen, what this issue seems to be about.

Nvd3 works with scrollable divs now, You don't need to change the container. You can use the default one.

anthonyettinger commented 9 years ago

Its still happening for us.

RenatoUtsch commented 9 years ago

Using the latest master commit?

anthonyettinger commented 9 years ago

Yes.

anthonyettinger commented 9 years ago

@altsang doesn't look like we're going to be able to fix this one given its current state.

@seanbrookes suggested that we remove the tooltip infavor of a static display of values above the chart that updated when you mouse over the data points rather than a buggy tooltip.

Please respond with how you want to proceed.

chandadharap commented 8 years ago

@altsang?

altsang commented 8 years ago

no follow up with the fix that was supposedly introduced in https://github.com/novus/nvd3/pull/851? the dev claims it's suppose to work with scrollable divs, did he drop out responding?

LalitAgrawala004 commented 7 years ago

@chandadharap @anthonyettinger is this issue fixed? I am having the issue (tooltip showing up bottom of the page) in only IE9.. any idea?