search

strongloop / strong-deploy

Deploy nodejs applications
Other
13 stars 3 forks source link

Add ability to deploy npm package (tarball) #4

Closed kraman closed 10 years ago

kraman commented 10 years ago

See also: https://github.com/strongloop/strong-pm/pull/12

kraman commented 10 years ago

@sam-github @rmg Please review when you get a chance.

rmg commented 10 years ago

Not so sure about the internals all referencing tarballs when none of the code is actually file format specific. I'd prefer the tarball references be kept to the higher level functions, if possible.

sam-github commented 10 years ago

Other than the two nits on capitalization of error messages, LGTM.