search

strongloop / strong-globalize

strong-globalize is built on Unicode CLDR and jquery/globalize and implements automatic extraction of strings from JS source code and HTML templates, lint the string resource, machine-translate them in seconds. In runtime, it loads locale and string resource into memory and provides a hook to persistent logging.
Other
25 stars 16 forks source link

Check that name passed to headerIncluded has indexOf function #103

Closed penguinpowernz closed 7 years ago

penguinpowernz commented 7 years ago

Sometimes this gets passed in as null and crashes the entire app. Since there is no way to match if it's nil, the best thing to do in this case seems to be just returning false.

slnode commented 7 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

slnode commented 7 years ago

Can one of the admins verify this patch?

penguinpowernz commented 7 years ago

Any luck with this? It keeps blowing out my Rollbar

image

/cc @raymondfeng

Setogit commented 7 years ago

connect to https://github.com/strongloop/strong-globalize/pull/109