search

strongloop / strong-globalize

strong-globalize is built on Unicode CLDR and jquery/globalize and implements automatic extraction of strings from JS source code and HTML templates, lint the string resource, machine-translate them in seconds. In runtime, it loads locale and string resource into memory and provides a hook to persistent logging.
Other
25 stars 16 forks source link

chore: rewrite the code in TypeScript and manage by lerna #132

Closed raymondfeng closed 6 years ago

raymondfeng commented 6 years ago

This is a port of existing code into TypeScript and split the module into 3 packages:

The three packages are hosted in the same github repository and managed using lerna.

raymondfeng commented 6 years ago

I see that test files are staying in JavaScript, is that intentional?

Yes, I wanted to do the conversion step by step to make sure existing tests can mostly pass as-is.

The top-level package.json limits engines to "node": ">=8", but package.json files in individual modules don't provide any engine config. At the same time, tsconfig is configured with es2017 target, therefore the lib code will require Node.js 8.x or newer. Please add engines config to all packages/*/package.json files.

Fixed.

bajtos commented 6 years ago

@raymondfeng I was looking around the new repo today and have few more comments:

Instructions for upgrading from 3.x to 4.x are gone from the main README.md, is this intentional?

There is no README in https://github.com/strongloop/strong-globalize/tree/master/packages/runtime, I think we need to fix this ASAP. Otherwise npmjs.com will not display any useful information for our users. Similarly for https://github.com/strongloop/strong-globalize/tree/master/packages/cli.

Ideally, these per-package READMEs should follow our README guidelines. Maybe we can move parts of the content from the monorepo-level README to individual packages where it makes more sense?

raymondfeng commented 6 years ago

Good catch for the README. I'm fix it with #133.

Please note that I made some changes in strong-globalize to keep it backward compatible (allowing both SG() and new SG(...). As a result, I have removed the breaking changes in README.