search

strongloop / strong-globalize

strong-globalize is built on Unicode CLDR and jquery/globalize and implements automatic extraction of strings from JS source code and HTML templates, lint the string resource, machine-translate them in seconds. In runtime, it loads locale and string resource into memory and provides a hook to persistent logging.
Other
25 stars 16 forks source link

Update`os-locale` to v3.0.1 #138

Closed Runrioter closed 6 years ago

Runrioter commented 6 years ago

We had updated strong-globalize in here https://github.com/strongloop/strong-soap/pull/189 because of mem.

So updateos-locale to v3.0.1 which use a safe mem and release a patch version. Everything will be OK.

Thanks.

slnode commented 6 years ago

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

Runrioter commented 6 years ago

CI failed. It is a pity that g11n-pipeline which strong-globalize-cli depends on requires Node 8 or later.

Can we drop supporting Node 6 ?

raymondfeng commented 6 years ago

We can drop Node 6 for the cli and release a new major. The runtime can continue to support Node 6.

Runrioter commented 6 years ago

Please review this

Thanks @raymondfeng