search

strongloop / strong-oracle

Deprecated: Node.js Driver for Oracle databases (Use https://github.com/oracle/node-oracledb instead)
Other
45 stars 18 forks source link

Wrap v8 API calls with nan to support node 0.10 & 0.11 #1

Closed raymondfeng closed 10 years ago

raymondfeng commented 10 years ago

/to @bnoordhuis /cc @ritch

bnoordhuis commented 10 years ago

LGTM, I think but I didn't test anything, I only looked at the diff.

We should go over the code together some time; I suspect there is much that can be RAII'd and DRY'd.

raymondfeng commented 10 years ago

Definitely, I would love to review the code with you in depth.