Closed raymondfeng closed 10 years ago
Raymond, as a general observation: memory management is way too ad hoc. I've found a handful of memory leaks already and there are probably more.
Use RAII more, embed types in other types, etc. 'new' should be used sparingly, there's often a better way to accomplish the same thing.
I fixed most of the issues that Ben raised. Most of them are inherited from node-oracle. Let's try to clean up the code in separate PRs.
/to @bnoordhuis
The PR fixes two issues: