search

strongloop / strong-oracle

Deprecated: Node.js Driver for Oracle databases (Use https://github.com/oracle/node-oracledb instead)
Other
45 stars 18 forks source link

Fix the oracle driver latency issues #2

Closed raymondfeng closed 10 years ago

raymondfeng commented 10 years ago

/to @bnoordhuis

The PR fixes two issues:

  1. Make the close() method async
  2. Move the expensive LOB reads out of the callback thread
bnoordhuis commented 10 years ago

Raymond, as a general observation: memory management is way too ad hoc. I've found a handful of memory leaks already and there are probably more.

Use RAII more, embed types in other types, etc. 'new' should be used sparingly, there's often a better way to accomplish the same thing.

raymondfeng commented 10 years ago

I fixed most of the issues that Ben raised. Most of them are inherited from node-oracle. Let's try to clean up the code in separate PRs.