search

strongloop / strong-oracle

Deprecated: Node.js Driver for Oracle databases (Use https://github.com/oracle/node-oracledb instead)
Other
45 stars 18 forks source link

Upgrade to nan 2.0.x #51

Closed raymondfeng closed 9 years ago

raymondfeng commented 9 years ago

/To @bnoordhuis

bnoordhuis commented 9 years ago

The ubuntu-0.10 buildbot is failing with what looks like memory corruption:

*** Error in `node': free(): invalid size: 0x00007f38840292d0 ***
Aborted (core dumped)

(EDIT: And what seems to be a NULL pointer deref in Connection::CreateV8ObjectFromRow().)

The Windows build is failing with what looks like a missing #include <time.h>:

..\src\connection.cpp(904): error C2228: left of '.ToLocalChecked' must have class/struct/union [D:\workspace\strong-oracle.pr\cd6b86e3\build\oracle_bindings.vcxproj]
..\src\connection.cpp(904): error C3861: 'time': identifier not found [D:\workspace\strong-oracle.pr\cd6b86e3\build\oracle_bindings.vcxproj]
..\src\connection.cpp(920): error C2228: left of '.ToLocalChecked' must have class/struct/union [D:\workspace\strong-oracle.pr\cd6b86e3\build\oracle_bindings.vcxproj]
..\src\connection.cpp(920): error C3861: 'time': identifier not found [D:\workspace\strong-oracle.pr\cd6b86e3\build\oracle_bindings.vcxproj]
raymondfeng commented 9 years ago

@bnoordhuis I fixed the time issue.

Can you help troubleshoot http://ci.strongloop.com/job/strong-oracle.pr/18/label=amazon-0.10/console? It seems that the crash is caused by GC of buffer.

raymondfeng commented 9 years ago

test please

raymondfeng commented 9 years ago

test please

bnoordhuis commented 9 years ago

It's possible that https://github.com/nodejs/node/pull/2912 fixes the GC crash.

ChALkeR commented 9 years ago

Adding to the list: https://github.com/nodejs/node/issues/2798.