search

strongloop / strong-oracle

Deprecated: Node.js Driver for Oracle databases (Use https://github.com/oracle/node-oracledb instead)
Other
45 stars 18 forks source link

Support for LONG RAW data type #54

Closed isaackehle closed 8 years ago

isaackehle commented 8 years ago

Hello. I am trying to pull data from a legacy system that uses the LONG RAW data type for one of its columns. It'd be really helpful for this package to support this data type (24). Oracle ODBC Driver Release 11.2.0.1.0 says that Prefetch for LONG RAW data types is supported.

https://docs.oracle.com/database/121/ADFNS/adfns_odbc.htm#BABBFBBG

I'm trying to tweak this package manually, but I'm not an expert in developing node packages.

EDIT: I would post this to the official node-oracledb project, but they have yet to finish upgrading to using NAN2 (so it seems) thus their package does not yet compile to Node v4.2.1.

isaackehle commented 8 years ago

I actually have code that is working for my purposes, that I would like to publish to a branch. It's at least a starting point.

raymondfeng commented 8 years ago

Would you like to submit a PR?

isaackehle commented 8 years ago

Ideally yes, but first at least push to a branch.

isaackehle commented 8 years ago

Can you please give me access to a branch, or let me know how I can send you a few files to do this for me? I figure there is one tweak in the code you might want to do, to remove a hard-coded value. But otherwise, pulls from the database seem to work for my purposes. Thanks.

raymondfeng commented 8 years ago

You can folk the repo into your own github account, change the code there, and then submit a pull request. See https://help.github.com/articles/using-pull-requests/

isaackehle commented 8 years ago

Got it. Hadn't done that specific action before (pull request from forked project). I see someone has already noticed this and commented. Thank you.

isaackehle commented 8 years ago

Marking this closed as the PR has been merged.