search

strongloop / strong-oracle

Deprecated: Node.js Driver for Oracle databases (Use https://github.com/oracle/node-oracledb instead)
Other
45 stars 18 forks source link

Ppc64fix #57

Closed elkorep closed 8 years ago

elkorep commented 8 years ago

Fixed the binding.gyp file by adding a condition that checks if it is ppc64. There is no oracle instantclient version 12 for power so we have to make sure binding.gyp knows that it is version 11 when the machine is Linux on power.

raymondfeng commented 8 years ago

@elkorep Please squash the commits and remove npm-debug.log.

smartmouse commented 8 years ago

the binding.gyp is relying on "OS" environment variable, I found that some of the profiles in the account have been set up differently. e.g. on plnx132.rtp.raleigh.ibm.com, if I echo $OS , it gives "rhel" and not "linux", on plnx133.rtp.raliegh.ibm.com, echo $OS will give "sles". @elkorep , do you why OS is set to those values, is it for jenkins?

raymondfeng commented 8 years ago

OS is probably a built-in var from gyp, not necessarily the env var.

elkorep commented 8 years ago

@raymondfeng I removed the npm-debug.log

bnoordhuis commented 8 years ago

LGTM FWIW. Can you squash your changes into a single commit with a nice commit log?