search

strongloop / strong-oracle

Deprecated: Node.js Driver for Oracle databases (Use https://github.com/oracle/node-oracledb instead)
Other
45 stars 18 forks source link

Fix issue with gcc5 and occi based on gcc4 #65

Closed vschoettke closed 8 years ago

vschoettke commented 8 years ago

After updating to a newer my Linux distro I got strange errors with strong-oracle e.g.:

[Error: ORA-24960: the attribute OCI_ATTR_USERNAME is greater than the maximum allowable length of 255]

and a crash after that.

After some research I found out that gcc 5 uses a new ABI and is incompatible with the occi that used gcc4. (See http://stackoverflow.com/questions/32309029/occi-linkage-error-with-gcc-5)

This fix adds the required definition so that the new ABI is disabled, older gcc ignore the definition.

bnoordhuis commented 8 years ago

LGTM with the caveat that node.js and V8 don't define _GLIBCXX_USE_CXX11_ABI =0. Their APIs generally don't use STL types so that's probably alright; the exceptions are in v8-profiler.h and v8-util.h but we don't use those.

/cc @raymondfeng

vschoettke commented 8 years ago

@raymondfeng bump!