Add option to deploy apps as docker containers - Githubissues

strongloop / strong-pm

deployer for node applications

http://strong-pm.io

Other

1k stars 71 forks source link

Add option to deploy apps as docker containers #189

Closed rmg closed 9 years ago

rmg commented 9 years ago

[x] start app in container when deployed
[x] deploy multiple apps
[x] resize cluster via slc ctl set-size 1 N
[x] restart app when env is modified
[x] replace app when re-deployed
- [x] remove killed processes when the docker container is stopped
[x] handle/simulate supervisor exit
[x] stop started app
[x] ~~handle instance containers already running when PM starts~~
- ignoring them for now
[x] collect logs and expose via log-dump
- will also give exit notification if the stream dies and cannot be resumed
[x] fully emulate started notification
- get real app name and agent version from app
[x] --driver option to specify direct vs. docker
[x] --driver option for sl-pm-install

Tests

[x] basic driver API tests
[ ] ???

Connect to strongloop-internal/scrum-nodeops#402 Connect to strongloop-internal/scrum-nodeops#484

sam-github commented 9 years ago

Needs linting.

sam-github commented 9 years ago

@rmg I'll drop 447cce7, its not needed, but we have to sort out what happens when pm is run consecutively with different driver types.

rmg commented 9 years ago

@sam-github it still lacks useful tests, but it's lint free and works for all my manual testing cases, so I think you can start reviewing now.

sam-github commented 9 years ago

Looks pretty good. The code is quite easy to follow, except for the instance juggling.

I've only read through the driver, I'll try to get through container and image tonight.

Could you get it running on ubuntu, so that I can do a bit of functional testing/trying it out?

sam-github commented 9 years ago

Appears to be running, but I can't curl the port that meshctl says is being listened on. docker inspect seems to imply the image is on port 3000, but I can't curl that, either.

sam-github commented 9 years ago

Basically LGTM other than a couple nits. And that I can't reach my apps that meshctl says are listening. I could use a docker tutorial, I think.

rmg commented 9 years ago

@sam-github would you like me to remove the new listening event I added? All it does is allow the PM logs to show sl-pm: Service "1" listening on 0.0.0.0:3001

rmg commented 9 years ago

Oh ya, I remember... the listening event and that filtering were both added in #194