Improve service installation support for docker driver

strongloop / strong-pm

deployer for node applications

http://strong-pm.io

Other

1k stars 71 forks source link

Improve service installation support for docker driver #222

Closed rmg closed 9 years ago

rmg commented 9 years ago

[x] run strong-pm as docker group
- minimal change, covers Upstart 1.4 and systemd
[x] add strong-pm user to docker group
- required to support Upstart 0.6 environments
[x] detect docker and fail if not found

connect to strongloop-internal/scrum-nodeops#615 connect to strongloop-internal/scrum-nodeops#618

rmg commented 9 years ago

Found and fixed a bug in the docker driver with env-unset along the way.

rmg commented 9 years ago

@slnode test please

rmg commented 9 years ago

@sam-github do you want me to rebase/squash this before you look at it?

sam-github commented 9 years ago

LGTM

rmg commented 9 years ago

@slnode test please

rmg commented 9 years ago

@sam-github had to make one more change to support 0.12/iojs, can you take one more pass at the latest commit to make sure I didn't do anything stupid?

rmg commented 9 years ago

@slnode test please

rmg commented 9 years ago

@slnode test please