search

strongloop / strong-pm

deployer for node applications
http://strong-pm.io
Other
1k stars 71 forks source link

Allow app base port to other than 3000 #223

Closed sam-github closed 9 years ago

sam-github commented 9 years ago

It defaults to 3000, but that isn't useful if you have apps running on your host in the 3000+ range already. Its also unworkable if you have multiple instances of pm on the same host.

should do for strong-central, as well.

connected to strongloop-internal/scrum-nodeops#623

/cc @seanbrookes @cgole

rmg commented 9 years ago

There's a call to getServiceEnv() on lib/service-manager.js:324 that looks like it needs to be updated to pass the basePort.

rmg commented 9 years ago

Also needs to be added to sl-pm-install.

sam-github commented 9 years ago

@slnode test please

sam-github commented 9 years ago

@slnode test please

rmg commented 9 years ago

I don't see any tests.. adding a couple lines to test/test-install.sh to verify that it propagates to the upstart job would be reasonable and should only take a few seconds to add.

rmg commented 9 years ago

Other than my very minor nits, LGTM.

sam-github commented 9 years ago

@slnode test please